You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for unknown type errors now includes an except clause for Firefox. This suggests there might be inconsistent behavior between browsers that should be documented or addressed in the implementation.
it'errors on unknown type',except: {browser: :firefox,reason: "Doesn't return the expected error"}do
The code uses wait_for_alert and wait_for_no_alert helper methods, but these aren't defined in the visible code. Ensure these helper methods are properly defined elsewhere.
The test uses wait.until to wait for the alert to appear, but uses a different method wait_for_alert in the other test cases. For consistency, use the same waiting mechanism across all alert tests.
it 'accepts users prompts without text' do
browsing_context = described_class.new(bridge)
driver.navigate.to url_for('alerts.html')
driver.find_element(id: 'alert').click
- wait.until { driver.switch_to.alert }+ wait_for_alert
window = driver.window_handles.first
browsing_context.handle_user_prompt(window, accept: true)
wait_for_no_alert
expect(driver.title).to eq('Testing Alerts')
end
Apply this suggestion
Suggestion importance[1-10]: 7
__
Why: The suggestion correctly identifies an inconsistency in how alerts are waited for across test cases. Standardizing on the wait_for_alert method improves code consistency and maintainability, making the test suite more uniform and easier to understand.
Medium
More
aguspe
changed the title
Fix BiDi tests errors
[rb] Fix BiDi tests errors
Mar 22, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Motivation and Context
We want our tests to be executed and pass for the BiDi implementation
This PR aims to fix the browser_context and network bidi tests
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
Fixed BiDi tests for browser context and network.
Updated error handling for unknown types in tests.
Improved handling of user prompts in browsing context tests.
Added cleanup step to reset driver in network tests.
Changes walkthrough 📝
browsing_context_spec.rb
Fix and enhance browsing context BiDi testsrb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb
driverwithbridgefor browsing context initialization.network_spec.rb
Enhance network BiDi tests with cleanuprb/spec/integration/selenium/webdriver/bidi/network_spec.rb